Skip to content

GleanPingView: Move all Glean internal metrics to a single category #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fbertsch opened this issue May 7, 2021 · 0 comments
Open
Labels
enhancement New feature or request Glean Changes for Glean Pings and automated Glean derived tables

Comments

@fbertsch
Copy link
Contributor

fbertsch commented May 7, 2021

We currently have several Glean internal metrics represented in the Glean Ping categories, mainly in the metrics ping. These include: glean.error, glean.validation, glean.database, etc.

We should move all of these to a single glean category. The remaining part of the actual category should be prepended to the dimension name. For example, we currently have:

dimension: metrics__memory_distribution__glean_database_size__sum {
    sql: ${TABLE}.metrics.memory_distribution.glean_database_size.sum ;;
    type: number
    group_label: "Glean Database"
    group_item_label: "Size Sum"
}

We would drop Database from the group_label, and prepend it to the group_item_label (We can also consider a separator to make it clear what is part of the category and what is the metric):

dimension: metrics__memory_distribution__glean_database_size__sum {
    sql: ${TABLE}.metrics.memory_distribution.glean_database_size.sum ;;
    type: number
    group_label: "Glean"
    group_item_label: "Database - Size Sum"
}
@fbertsch fbertsch added Glean Changes for Glean Pings and automated Glean derived tables enhancement New feature or request labels May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Glean Changes for Glean Pings and automated Glean derived tables
Projects
None yet
Development

No branches or pull requests

1 participant